Commit 0d8a52f9 authored Nov 04, 2014 by Dan Carpenter Committed by Marcel Holtmann Nov 04, 2014

ieee802154: || vs && in ieee802154_is_valid_extended_addr()



The ieee802154_is_valid_extended_addr() always returns true because
there is a typo.  The || should be &&.  Neither 0x0000000000000000ULL
nor 0xffffffffffffffffULL are valid addresses.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent 980edbd5

include/linux/ieee802154.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -209,7 +209,7 @@ static inline bool ieee802154_is_valid_extended_addr(const __le64 addr)
		* This is currently a workaround because neighbor discovery can't
		* deal with short addresses types right now.
		*/
		return ((addr != cpu_to_le64(0x0000000000000000ULL)) \|\|
		return ((addr != cpu_to_le64(0x0000000000000000ULL)) &&
		(addr != cpu_to_le64(0xffffffffffffffffULL)));
		}