Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d5edc68 authored by Cong Wang's avatar Cong Wang Committed by David S. Miller
Browse files

ipv4, route: pass 0 instead of LOOPBACK_IFINDEX to fib_validate_source() 



In my special case, when a packet is redirected from veth0 to lo,
its skb->dev->ifindex would be LOOPBACK_IFINDEX. Meanwhile we
pass the hard-coded LOOPBACK_IFINDEX to fib_validate_source()
in ip_route_input_slow(). This would cause the following check
in fib_validate_source() fail:

            (dev->ifindex != oif || !IN_DEV_TX_REDIRECTS(idev))

when rp_filter is disabeld on loopback. As suggested by Julian,
the caller should pass 0 here so that we will not end up by
calling __fib_validate_source().

Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Julian Anastasov <ja@ssi.bg>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: default avatarCong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: default avatarCong Wang <cwang@twopensource.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6a662719

net/ipv4/route.c

+1 −2
Original line number Diff line number Diff line
@@ -1700,8 +1700,7 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr, 


	if (res.type == RTN_LOCAL) {

		err = fib_validate_source(skb, saddr, daddr, tos,

					  LOOPBACK_IFINDEX,

					  dev, in_dev, &itag);

					  0, dev, in_dev, &itag);

		if (err < 0)

			goto martian_source_keep_err;

		goto local_input;