Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0cf7a633 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman
Browse files

USB: gadget: amd5536udc.c: Remove double test 

The same expression is tested twice and the result is the same each time.
Instead test for use_dma_ppb as in the test above.

The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@expression@
expression E;
@@

(
* E
  || ... || E
|
* E
  && ... && E
)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 5ea08178

drivers/usb/gadget/amd5536udc.c

+1 −1
Original line number Diff line number Diff line
@@ -203,7 +203,7 @@ static void print_regs(struct udc *dev) 
		DBG(dev, "DMA mode       = PPBNDU (packet per buffer "

			"WITHOUT desc. update)\n");

		dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU");

	} else if (use_dma && use_dma_ppb_du && use_dma_ppb_du) {

	} else if (use_dma && use_dma_ppb && use_dma_ppb_du) {

		DBG(dev, "DMA mode       = PPBDU (packet per buffer "

			"WITH desc. update)\n");

		dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBDU");