Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c49cc16 authored by Aaro Koskinen's avatar Aaro Koskinen Committed by Tony Lindgren
Browse files

OMAP3+: smartreflex: fix ioremap leak on probe error 



Add missing iounmap() to error paths.

Signed-off-by: default avatarAaro Koskinen <aaro.koskinen@nokia.com>
Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
parent da9e7392

arch/arm/mach-omap2/smartreflex.c

+6 −4
Original line number Diff line number Diff line
@@ -904,7 +904,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) 
	vdd_dbg_dir = omap_voltage_get_dbgdir(sr_info->voltdm);

	if (!vdd_dbg_dir) {

		ret = -EINVAL;

		goto err_release_region;

		goto err_iounmap;

	}



	sr_info->dbg_dir = debugfs_create_dir("smartreflex", vdd_dbg_dir);
@@ -912,7 +912,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) 
		dev_err(&pdev->dev, "%s: Unable to create debugfs directory\n",

			__func__);

		ret = PTR_ERR(sr_info->dbg_dir);

		goto err_release_region;

		goto err_iounmap;

	}



	(void) debugfs_create_file("autocomp", S_IRUGO | S_IWUSR,
@@ -929,7 +929,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) 
		dev_err(&pdev->dev, "%s: Unable to create debugfs directory"

			"for n-values\n", __func__);

		ret = PTR_ERR(nvalue_dir);

		goto err_release_region;

		goto err_iounmap;

	}



	omap_voltage_get_volttable(sr_info->voltdm, &volt_data);
@@ -939,7 +939,7 @@ static int __init omap_sr_probe(struct platform_device *pdev) 
			"entries for n-values\n",

			__func__, sr_info->voltdm->name);

		ret = -ENODATA;

		goto err_release_region;

		goto err_iounmap;

	}



	for (i = 0; i < sr_info->nvalue_count; i++) {
@@ -953,6 +953,8 @@ static int __init omap_sr_probe(struct platform_device *pdev) 


	return ret;



err_iounmap:

	iounmap(sr_info->base);

err_release_region:

	release_mem_region(mem->start, resource_size(mem));

err_free_devinfo: