Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0c25a850 authored by Ming Lei's avatar Ming Lei Committed by Greg Kroah-Hartman
Browse files

firmware loader: remove unnecessary wmb() 



The wmb() inside fw_load_abort is not necessary, since
complete() and wait_on_completion() has implied one pair
of memory barrier.

Also wmb() isn't a correct usage, so just remove it.

Signed-off-by: default avatarMing Lei <ming.lei@canonical.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 28eefa75

drivers/base/firmware_class.c

+0 −1
Original line number Diff line number Diff line
@@ -112,7 +112,6 @@ static struct firmware_priv *to_firmware_priv(struct device *dev) 
static void fw_load_abort(struct firmware_priv *fw_priv)

{

	set_bit(FW_STATUS_ABORT, &fw_priv->status);

	wmb();

	complete(&fw_priv->completion);

}