Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0ae90252 authored by Jarod Wilson's avatar Jarod Wilson Committed by Mauro Carvalho Chehab
Browse files

[media] fintek-cir: make suspend with active IR more reliable 



There was a missing lock in fintek_suspend. Without the lock, its
possible the system will be in the middle of receiving IR (draining the
RX buffer) when we try to disable CIR interrupts.

Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 8de111e2

drivers/media/rc/fintek-cir.c

+5 −0
Original line number Diff line number Diff line
@@ -597,12 +597,17 @@ static void __devexit fintek_remove(struct pnp_dev *pdev) 
static int fintek_suspend(struct pnp_dev *pdev, pm_message_t state)

{

	struct fintek_dev *fintek = pnp_get_drvdata(pdev);

	unsigned long flags;



	fit_dbg("%s called", __func__);



	spin_lock_irqsave(&fintek->fintek_lock, flags);



	/* disable all CIR interrupts */

	fintek_cir_reg_write(fintek, CIR_STATUS_IRQ_MASK, CIR_STATUS);



	spin_unlock_irqrestore(&fintek->fintek_lock, flags);



	fintek_config_mode_enable(fintek);



	/* disable cir logical dev */