Commit 09dd7703 authored Jul 19, 2016 by Jason Gunthorpe Committed by Jarkko Sakkinen Sep 15, 2016

tpm/st33zp24: Remove useless tpm_gen_interrupt

This function should only be called as part of an IRQ probing protocol
and st33 does not have any code to detect that the IRQ it tries to
generate was not generated and disable the IRQ.

Since st33 is primarily a DT binding driver it should not be doing
IRQ probing anyhow, so let us just delete this useless call.

Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

parent d4816edf

drivers/char/tpm/st33zp24/st33zp24.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -589,8 +589,6 @@ int st33zp24_probe(void phy_id, const struct st33zp24_phy_ops ops,
		chip->flags \|= TPM_CHIP_FLAG_IRQ;

		disable_irq_nosync(tpm_dev->irq);

		tpm_gen_interrupt(chip);
		}

		return tpm_chip_register(chip);