Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 07bb6bdd authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] siano: remove a bogus printk line 



The logic that detects the types of sms devices is bogus. It returns
	[ 4645.187790] smsusb_init_device: line: 372: Unspecified sms device type!
For several devices, including the one I have (SMS_RIO). In a matter
of fact, the right thing to do there is to print an error only if
the device is really unknown (SMS_UNKNOWN_TYPE).

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent beb91d46

drivers/media/usb/siano/smsusb.c

+2 −6
Original line number Diff line number Diff line
@@ -368,14 +368,10 @@ static int smsusb_init_device(struct usb_interface *intf, int board_id) 
		params.setmode_handler = smsusb1_setmode;

		params.detectmode_handler = smsusb1_detectmode;

		break;

	default:

	case SMS_UNKNOWN_TYPE:

		sms_err("Unspecified sms device type!");

		/* fall-thru */

	case SMS_NOVA_A0:

	case SMS_NOVA_B0:

	case SMS_VEGA:

	case SMS_VENICE:

	case SMS_DENVER_1530:

	default:

		dev->buffer_size = USB2_BUFFER_SIZE;

		dev->response_alignment =

		    le16_to_cpu(dev->udev->ep_in[1]->desc.wMaxPacketSize) -