Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 070718a4 authored by Christophe Ricard's avatar Christophe Ricard Committed by Samuel Ortiz
Browse files

NFC: st21nfca: Drop two useless checks in ACPI probe path 



When st21nfca_hci_i2c_acpi_request_resources() gets called we
already know that the entries in ->acpi_match_table have matched
ACPI ID of the device.
In addition I2C client pointer cannot be NULL in any case
(otherwise I2C core would not call ->probe() for the driver in
the first place).

Drop the two useless checks from the driver.

Signed-off-by: default avatarChristophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 7cb6ab59

drivers/nfc/st21nfca/i2c.c

+1 −12
Original line number Diff line number Diff line
@@ -507,21 +507,10 @@ static struct nfc_phy_ops i2c_phy_ops = { 
static int st21nfca_hci_i2c_acpi_request_resources(struct i2c_client *client)

{

	struct st21nfca_i2c_phy *phy = i2c_get_clientdata(client);

	const struct acpi_device_id *id;

	struct gpio_desc *gpiod_ena;

	struct device *dev;

	struct device *dev = &client->dev;

	u8 tmp;



	if (!client)

		return -EINVAL;



	dev = &client->dev;



	/* Match the struct device against a given list of ACPI IDs */

	id = acpi_match_device(dev->driver->acpi_match_table, dev);

	if (!id)

		return -ENODEV;



	/* Get EN GPIO from ACPI */

	gpiod_ena = devm_gpiod_get_index(dev, ST21NFCA_GPIO_NAME_EN, 1,

					 GPIOD_OUT_LOW);