drivers: net: cpsw: use of_phy_connect() in fixed-link case (06cd6d6e) · Commits · e / devices / android_kernel_teracube_2e

If a fixed-link DT subnode is used, the phy_device was looked up so that a PHY ID string could be constructed and passed to phy_connect(). This is not necessary, as the device_node can be passed directly to of_phy_connect() instead. This reuses the same codepath as if the phy-handle DT property was used. Signed-off-by:

David Rivshin <drivshin@allworx.com> Tested-by:

Nicolas Chauvet <kwizart@gmail.com> Tested-by:

Andrew Goodbody <andrew.goodbody@cambrionix.com> Reviewed-by:

Mugunthan V N <mugunthanvnm@ti.com> Reviewed-by:

Grygorii Strashko <grygorii.strashko@ti.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/ti/cpsw.c

+1 −10

Original line number	Diff line number	Diff line
		@@ -2048,22 +2048,13 @@ static int cpsw_probe_dt(struct cpsw_platform_data *data,
		"slave[%d] using phy-handle=\"%s\"\n",
		i, slave_data->phy_node->full_name);
		} else if (of_phy_is_fixed_link(slave_node)) {
		struct device_node *phy_node;
		struct phy_device *phy_dev;

		/* In the case of a fixed PHY, the DT node associated
		* to the PHY is the Ethernet MAC DT node.
		*/
		ret = of_phy_register_fixed_link(slave_node);
		if (ret)
		return ret;
		phy_node = of_node_get(slave_node);
		phy_dev = of_phy_find_device(phy_node);
		if (!phy_dev)
		return -ENODEV;
		snprintf(slave_data->phy_id, sizeof(slave_data->phy_id),
		PHY_ID_FMT, phy_dev->mdio.bus->id,
		phy_dev->mdio.addr);
		slave_data->phy_node = of_node_get(slave_node);
		} else if (parp) {
		u32 phyid;
		struct device_node *mdio_node;