Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06b446c8 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

Revert "Staging: comedi: integer overflow in do_insnlist_ioctl()" 



This reverts commit e384a411.
It's not the correct way to solve this issue.

Acked-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent e384a411

drivers/staging/comedi/comedi_fops.c

+0 −5
Original line number Original line Diff line number Diff line
@@ -670,11 +670,6 @@ static int do_insnlist_ioctl(struct comedi_device *dev, 
		goto error;

		goto error;

	}

	}





	if (sizeof(struct comedi_insn) * insnlist.n_insns < insnlist.n_insns) {

		ret = -EINVAL;

		goto error;

	}



	insns =

	insns =

	    kmalloc(sizeof(struct comedi_insn) * insnlist.n_insns, GFP_KERNEL);

	    kmalloc(sizeof(struct comedi_insn) * insnlist.n_insns, GFP_KERNEL);

	if (!insns) {

	if (!insns) {