Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0675363a authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman
Browse files

greybus: firmware: s/should/must 



Replace 'should' with 'must' to clear the expectation a bit more.

Reported-by: default avatarAlex Elder <alex.elder@linaro.org>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent b2abeaa1

drivers/staging/greybus/fw-download.c

+1 −1
Original line number Diff line number Diff line
@@ -238,7 +238,7 @@ static int fw_download_find_firmware(struct gb_operation *op) 
	request = op->request->payload;

	tag = (const char *)request->firmware_tag;



	/* firmware_tag should be null-terminated */

	/* firmware_tag must be null-terminated */

	if (strnlen(tag, GB_FIRMWARE_TAG_MAX_SIZE) == GB_FIRMWARE_TAG_MAX_SIZE) {

		dev_err(fw_download->parent,

			"firmware-tag is not null-terminated\n");