Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 066000dd authored by Ananth N Mavinakayanahalli's avatar Ananth N Mavinakayanahalli Committed by Linus Torvalds
Browse files

Revert "x86, apic: Use logical flat on intel with <= 8 logical cpus" 



Revert commit 2fbd07a5, as this commit
breaks an IBM platform with quad-core Xeon cpu's.

According to Suresh, this might be an IBM platform issue, as on other
Intel platforms with <= 8 logical cpu's, logical flat mode works fine
irespective of physical apic id values (inline with the xapic
architecture).

Revert this for now because of the IBM platform breakage.

Another version will be re-submitted after the complete analysis.

Signed-off-by: default avatarAnanth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: default avatarSuresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 1b4d40a5

arch/x86/kernel/apic/apic.c

+18 −8
Original line number Diff line number Diff line
@@ -62,7 +62,7 @@ unsigned int boot_cpu_physical_apicid = -1U; 
/*

 * The highest APIC ID seen during enumeration.

 *

 * On AMD, this determines the messaging protocol we can use: if all APIC IDs

 * This determines the messaging protocol we can use: if all APIC IDs

 * are in the 0 ... 7 range, then we can use logical addressing which

 * has some performance advantages (better broadcasting).

 *
@@ -1898,15 +1898,25 @@ void __cpuinit generic_processor_info(int apicid, int version) 
		max_physical_apicid = apicid;



#ifdef CONFIG_X86_32

	/*

	 * Would be preferable to switch to bigsmp when CONFIG_HOTPLUG_CPU=y

	 * but we need to work other dependencies like SMP_SUSPEND etc

	 * before this can be done without some confusion.

	 * if (CPU_HOTPLUG_ENABLED || num_processors > 8)

	 *       - Ashok Raj <ashok.raj@intel.com>

	 */

	if (max_physical_apicid >= 8) {

		switch (boot_cpu_data.x86_vendor) {

		case X86_VENDOR_INTEL:

		if (num_processors > 8)

			def_to_bigsmp = 1;

			if (!APIC_XAPIC(version)) {

				def_to_bigsmp = 0;

				break;

			}

			/* If P4 and above fall through */

		case X86_VENDOR_AMD:

		if (max_physical_apicid >= 8)

			def_to_bigsmp = 1;

		}

	}

#endif



#if defined(CONFIG_SMP) || defined(CONFIG_X86_64)

arch/x86/kernel/apic/probe_64.c

+4 −11
Original line number Diff line number Diff line
@@ -64,22 +64,15 @@ void __init default_setup_apic_routing(void) 
			apic = &apic_x2apic_phys;

		else

			apic = &apic_x2apic_cluster;

		printk(KERN_INFO "Setting APIC routing to %s\n", apic->name);

	}

#endif



	if (apic == &apic_flat) {

		switch (boot_cpu_data.x86_vendor) {

		case X86_VENDOR_INTEL:

			if (num_processors > 8)

				apic = &apic_physflat;

			break;

		case X86_VENDOR_AMD:

		if (max_physical_apicid >= 8)

			apic = &apic_physflat;

		}

	}



		printk(KERN_INFO "Setting APIC routing to %s\n", apic->name);

	}



	if (is_vsmp_box()) {

		/* need to update phys_pkg_id */