Commit 05b217b0 authored Jul 24, 2011 by Thomas Gleixner Committed by Ingo Molnar Sep 12, 2011

x86: cache_info: Remove bogus free of amd_l3_cache data



free_cache_attributes() kfree's:

   per_cpu(ici_cpuid4_info, cpu)->l3

which is a pointer to memory which was allocated as a block in
amd_init_l3_cache(). l3 of a particular cpu points to a part of this
memory blob. The part and the rest of the blob are still referenced by
other cpus.

As far as I can tell from the git history this is a leftover from the
conversion from per cpu to node data with commit ba06edb6(x86,
cacheinfo: Make L3 cache info per node) and the following commit
f658bcfb(x86, cacheinfo: Cleanup L3 cache index disable support)

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Hans Rosenfeld <hans.rosenfeld@amd.com>
Cc: Borislav Petkov <borislav.petkov@amd.com>
Cc: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: Mike Travis <travis@sgi.com>
Link: http://lkml.kernel.org/r/20110723212626.550539989@linutronix.de


Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 5cdd174f

arch/x86/kernel/cpu/intel_cacheinfo.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -820,7 +820,6 @@ static void __cpuinit free_cache_attributes(unsigned int cpu)
		for (i = 0; i < num_cache_leaves; i++)
		cache_remove_shared_cpu_map(cpu, i);

		kfree(per_cpu(ici_cpuid4_info, cpu)->l3);
		kfree(per_cpu(ici_cpuid4_info, cpu));
		per_cpu(ici_cpuid4_info, cpu) = NULL;
		}