Commit 059802f9 authored Jul 29, 2014 by Peter Senna Tschudin Committed by Rafael J. Wysocki Jul 30, 2014

cpupower: Remove redundant error check



Remove double checks, and move the call to print_error to the
first check. Replace break by return, and return 0 on success.
The simplified version of the coccinelle semantic patch that
fixes this issue is as follows:

// <smpl>
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
-	if (E) break;
+	if (E){
+		pr(es);
+		break;
+	}
...
}
- if(E) pr(es);
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 13f6de52

tools/power/cpupower/utils/cpufreq-set.c

+5 −6

Original line number	Diff line number	Diff line
		@@ -320,12 +320,11 @@ int cmd_freq_set(int argc, char **argv)

		printf(_("Setting cpu: %d\n"), cpu);
		ret = do_one_cpu(cpu, &new_pol, freq, policychange);
		if (ret)
		break;
		}

		if (ret)
		if (ret) {
		print_error();

		return ret;
		}
		}

		return 0;
		}