Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 057f6061 authored by Chen Gang's avatar Chen Gang Committed by Mark Brown
Browse files

spi: spi-bfin5xx: Initialize cr_width in bfin_spi_pump_transfers() 



cr_width may be not initialized before using by cr, the related warning
(with defconfig under blackfin by gcc5):

    CC      drivers/spi/spi-bfin5xx.o
  drivers/spi/spi-bfin5xx.c: In function 'bfin_spi_pump_transfers':
  drivers/spi/spi-bfin5xx.c:655:5: warning: 'cr_width' may be used uninitialized in this function [-Wmaybe-uninitialized]
    cr |= cr_width;
       ^

Signed-off-by: default avatarChen Gang <gang.chen.5i5j@gmail.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c517d838

drivers/spi/spi-bfin5xx.c

+1 −2
Original line number Diff line number Diff line
@@ -559,7 +559,7 @@ static void bfin_spi_pump_transfers(unsigned long data) 
	struct spi_transfer *previous = NULL;

	struct bfin_spi_slave_data *chip = NULL;

	unsigned int bits_per_word;

	u16 cr, cr_width, dma_width, dma_config;

	u16 cr, cr_width = 0, dma_width, dma_config;

	u32 tranf_success = 1;

	u8 full_duplex = 0;
@@ -648,7 +648,6 @@ static void bfin_spi_pump_transfers(unsigned long data) 
	} else if (bits_per_word == 8) {

		drv_data->n_bytes = bits_per_word/8;

		drv_data->len = transfer->len;

		cr_width = 0;

		drv_data->ops = &bfin_bfin_spi_transfer_ops_u8;

	}

	cr = bfin_read(&drv_data->regs->ctl) & ~(BIT_CTL_TIMOD | BIT_CTL_WORDSIZE);