Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 05675de2 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

device create: s390: convert device_create to device_create_drvdata 



device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.

Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent e17da9c4

drivers/s390/char/raw3270.c

+8 −6
Original line number Diff line number Diff line
@@ -1168,16 +1168,18 @@ static int raw3270_create_attributes(struct raw3270 *rp) 
	if (rc)

		goto out;



	rp->clttydev = device_create(class3270, &rp->cdev->dev,

	rp->clttydev = device_create_drvdata(class3270, &rp->cdev->dev,

					     MKDEV(IBM_TTY3270_MAJOR, rp->minor),

					     NULL,

					     "tty%s", rp->cdev->dev.bus_id);

	if (IS_ERR(rp->clttydev)) {

		rc = PTR_ERR(rp->clttydev);

		goto out_ttydev;

	}



	rp->cltubdev = device_create(class3270, &rp->cdev->dev,

	rp->cltubdev = device_create_drvdata(class3270, &rp->cdev->dev,

					     MKDEV(IBM_FS3270_MAJOR, rp->minor),

					     NULL,

					     "tub%s", rp->cdev->dev.bus_id);

	if (!IS_ERR(rp->cltubdev))

		goto out;

drivers/s390/char/tape_class.c

+3 −4
Original line number Diff line number Diff line
@@ -69,10 +69,9 @@ struct tape_class_device *register_tape_dev( 
	if (rc)

		goto fail_with_cdev;



	tcd->class_device = device_create(tape_class, device,

	tcd->class_device = device_create_drvdata(tape_class, device,

						  tcd->char_device->dev,

					  "%s", tcd->device_name

			);

						  NULL, "%s", tcd->device_name);

	rc = IS_ERR(tcd->class_device) ? PTR_ERR(tcd->class_device) : 0;

	if (rc)

		goto fail_with_cdev;

drivers/s390/char/vmur.c

+3 −2
Original line number Diff line number Diff line
@@ -896,7 +896,8 @@ static int ur_set_online(struct ccw_device *cdev) 
		goto fail_free_cdev;

	}



	urd->device = device_create(vmur_class, NULL, urd->char_device->dev,

	urd->device = device_create_drvdata(vmur_class, NULL,

					    urd->char_device->dev, NULL,

					    "%s", node_id);

	if (IS_ERR(urd->device)) {

		rc = PTR_ERR(urd->device);