Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 03b0a528 authored by Igor Kotrasinski's avatar Igor Kotrasinski Committed by Greg Kroah-Hartman
Browse files

usbip: vhci_hcd: only return urb at enqueue when served 



We handle USB_REQ_SET_ADDRESS at enqueue, so we want to perform
cleanup and giveback the urb. We should not call usb_hcd_giveback_urb
when we're cleaning up after a failed enqueue, though.

Only giveback the urb at cleanup when we claim to have served it.

Signed-off-by: default avatarIgor Kotrasinski <i.kotrasinsk@samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0c43e9d8

drivers/usb/usbip/vhci_hcd.c

+3 −1
Original line number Diff line number Diff line
@@ -565,7 +565,9 @@ static int vhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb, 
	usb_hcd_unlink_urb_from_ep(hcd, urb);

no_need_unlink:

	spin_unlock(&the_controller->lock);

	usb_hcd_giveback_urb(vhci_to_hcd(the_controller), urb, urb->status);

	if (!ret)

		usb_hcd_giveback_urb(vhci_to_hcd(the_controller),

				     urb, urb->status);

	return ret;

}