Commit 024a07ba authored Jun 06, 2010 by Timo Teräs Committed by David S. Miller Jun 06, 2010

r8169: fix random mdio_write failures



Some configurations need delay between the "write completed" indication
and new write to work reliably.

Realtek driver seems to use longer delay when polling the "write complete"
bit, so it waits long enough between writes with high probability (but
could probably break too). This patch adds a new udelay to make sure we
wait unconditionally some time after the write complete indication.

This caused a regression with XID 18000000 boards when the board specific
phy configuration writing many mdio registers was added in commit
2e955856 (r8169: phy init for the 8169scd). Some of the configration
mdio writes would almost always fail, and depending on failure might leave
the PHY in non-working state.

Signed-off-by: Timo Teräs <timo.teras@iki.fi>
Acked-off-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8ffb335e

drivers/net/r8169.c

+5 −0

Original line number	Original line	Diff line number	Diff line
	@@ -559,6 +559,11 @@ static void mdio_write(void __iomem *ioaddr, int reg_addr, int value)
	break;		break;
	udelay(25);		udelay(25);
	}		}
			/*
			* Some configurations require a small delay even after the write
			* completed indication or the next write might fail.
			*/
			udelay(25);
	}		}

	static int mdio_read(void __iomem *ioaddr, int reg_addr)		static int mdio_read(void __iomem *ioaddr, int reg_addr)