Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0173c895 authored by Andy Green's avatar Andy Green Committed by Vinod Koul
Browse files

k3dma: Fix "nobody cared" message seen on any error 



As it was before, as soon as the DMAC IP felt there was an error
he would return IRQ_NONE since no actual transfer had completed.

After spinning on that for 100K interrupts, Linux yanks the IRQ with
a "nobody cared" error.

This patch lets it handle the interrupt and keep the IRQ alive.

Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Andy Green <andy@warmcat.com>
Acked-by: default avatarZhangfei Gao <zhangfei.gao@linaro.org>
Signed-off-by: default avatarAndy Green <andy.green@linaro.org>
[jstultz: Forward ported to mainline]
Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent aceaaa17

drivers/dma/k3dma.c

+5 −3
Original line number Diff line number Diff line
@@ -221,10 +221,12 @@ static irqreturn_t k3_dma_int_handler(int irq, void *dev_id) 
	writel_relaxed(err1, d->base + INT_ERR1_RAW);

	writel_relaxed(err2, d->base + INT_ERR2_RAW);



	if (irq_chan) {

	if (irq_chan)

		tasklet_schedule(&d->task);



	if (irq_chan || err1 || err2)

		return IRQ_HANDLED;

	} else



	return IRQ_NONE;

}