Commit 011f0e7a authored Jan 12, 2015 by Michael S. Tsirkin Committed by Rusty Russell Jan 21, 2015

virtio/console: verify device has config space



Some devices might not implement config space access
(e.g. remoteproc used not to - before 3.9).
virtio/console needs config space access so make it
fail gracefully if not there.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

parent a4379fd8

drivers/char/virtio_console.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1986,6 +1986,12 @@ static int virtcons_probe(struct virtio_device *vdev)
		bool multiport;
		bool early = early_put_chars != NULL;

		if (!vdev->config->get) {
		dev_err(&vdev->dev, "%s failure: config access disabled\n",
		__func__);
		return -EINVAL;
		}

		/* Ensure to read early_put_chars now */
		barrier();