Commit 00b8c95b authored Mar 24, 2015 by Chengyu Song Committed by Steve French May 20, 2015

cifs: potential missing check for posix_lock_file_wait

posix_lock_file_wait may fail under certain circumstances, and its result is
usually checked/returned. But given the complexity of cifs, I'm not sure if
the result is intentially left unchecked and always expected to succeed.

Signed-off-by: Chengyu Song <csong84@gatech.edu>
Acked-by: Jeff Layton <jeff.layton@primarydata.com>
Signed-off-by: Steve French <smfrench@gmail.com>

parent 7196ac11

fs/cifs/file.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1552,8 +1552,8 @@ cifs_setlk(struct file file, struct file_lock flock, __u32 type,
		rc = server->ops->mand_unlock_range(cfile, flock, xid);

		out:
		if (flock->fl_flags & FL_POSIX)
		posix_lock_file_wait(file, flock);
		if (flock->fl_flags & FL_POSIX && !rc)
		rc = posix_lock_file_wait(file, flock);
		return rc;
		}