Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 00b15628 authored by Bojan Prtvar's avatar Bojan Prtvar Committed by Jiri Kosina
Browse files

HID: prodikeys: kfree() NULL pointer cleanup 



No need for freeing pm in case when it's not allocated.

Reported-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarBojan Prtvar <prtvar.b@gmail.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 6371fe54

drivers/hid/hid-prodikeys.c

+4 −4
Original line number Diff line number Diff line
@@ -816,7 +816,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id) 
	if (pm == NULL) {

		hid_err(hdev, "can't alloc descriptor\n");

		ret = -ENOMEM;

		goto err_free;

		goto err_free_pk;

	}



	pm->pk = pk;
@@ -849,10 +849,10 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id) 
err_stop:

	hid_hw_stop(hdev);

err_free:

	if (pm != NULL)

	kfree(pm);



err_free_pk:

	kfree(pk);



	return ret;

}