Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fffa33d5 authored by Syed Rameez Mustafa's avatar Syed Rameez Mustafa Committed by David Keitel
Browse files

sched: Avoid pulling big tasks to the little cluster during load balance 



When a lower capacity CPU attempts to pull work from a higher capacity CPU,
during load balance, it does not distinguish between tasks that will fit
or not fit on the destination CPU. This causes suboptimal load balancing
decisions whereby big tasks end up on the lower capacity CPUs and little
tasks remain on higher capacity CPUs. Avoid this behavior, by first
restricting search to only include tasks that fit on the destination CPU.
If such a task cannot be found, remove this restriction so that any task
can be pulled over to the destination CPU. This behavior is not applicable
during sched_boost, however, as none of the tasks will fit on a lower
capacity CPU.

Change-Id: I1093420a629a0886fc3375849372ab7cf42e928e
Signed-off-by: default avatarSyed Rameez Mustafa <rameezmustafa@codeaurora.org>
[joonwoop@codeaurora.org: fixed minor conflict in can_migrate_task().]
Signed-off-by: default avatarJoonwoo Park <joonwoop@codeaurora.org>
parent dbd548ae

kernel/sched/fair.c

+24 −4
Original line number Diff line number Diff line
@@ -7395,6 +7395,7 @@ enum fbq_type { regular, remote, all }; 
#define LBF_IGNORE_SMALL_TASKS 0x10

#define LBF_PWR_ACTIVE_BALANCE 0x20

#define LBF_SCHED_BOOST 0x40

#define LBF_IGNORE_BIG_TASKS 0x80



struct lb_env {

	struct sched_domain	*sd;
@@ -7522,6 +7523,7 @@ static 
int can_migrate_task(struct task_struct *p, struct lb_env *env)

{

	int tsk_cache_hot;

	int twf;



	lockdep_assert_held(&env->src_rq->lock);
@@ -7543,8 +7545,22 @@ int can_migrate_task(struct task_struct *p, struct lb_env *env) 
	if (env->flags & LBF_IGNORE_SMALL_TASKS && is_small_task(p))

		return 0;



	if (!task_will_fit(p, env->dst_cpu) &&

			env->busiest_nr_running <= env->busiest_grp_capacity)

	twf = task_will_fit(p, env->dst_cpu);



	/*

	 * Attempt to not pull tasks that don't fit. We may get lucky and find

	 * one that actually fits.

	 */

	if (env->flags & LBF_IGNORE_BIG_TASKS && !twf)

		return 0;



	/*

	 * Group imbalance can sometimes cause work to be pulled across groups

	 * even though the group could have managed the imbalance on its own.

	 * Prevent inter-cluster migrations for big tasks when the number of

	 * tasks is lower than the capacity of the group.

	 */

	if (!twf && env->busiest_nr_running <= env->busiest_grp_capacity)

		return 0;



	if (!cpumask_test_cpu(env->dst_cpu, tsk_cpus_allowed(p))) {
@@ -7677,6 +7693,9 @@ static int detach_tasks(struct lb_env *env) 


	if (capacity(env->dst_rq) > capacity(env->src_rq))

		env->flags |= LBF_IGNORE_SMALL_TASKS;

	else if (capacity(env->dst_rq) < capacity(env->src_rq) &&

							!sched_boost())

		env->flags |= LBF_IGNORE_BIG_TASKS;



redo:

	while (!list_empty(tasks)) {
@@ -7741,9 +7760,10 @@ next: 
		list_move_tail(&p->se.group_node, tasks);

	}



	if (env->flags & LBF_IGNORE_SMALL_TASKS && !detached) {

	if (env->flags & (LBF_IGNORE_SMALL_TASKS | LBF_IGNORE_BIG_TASKS)

							     && !detached) {

		tasks = &env->src_rq->cfs_tasks;

		env->flags &= ~LBF_IGNORE_SMALL_TASKS;

		env->flags &= ~(LBF_IGNORE_SMALL_TASKS | LBF_IGNORE_BIG_TASKS);

		env->loop = orig_loop;

		goto redo;

	}