Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fde7308e authored by Gaurav Singhal's avatar Gaurav Singhal Committed by Gerrit - the friendly Code Review server
Browse files

Revert "drivercore: Avoid adding devices without pm_ops to dpm list" 



This reverts commit d36bb308.

Not able to add device with PM core and causing suspend/resume
issue in I2C client driver.pm_ops are removed from I2C bus type
and should fall back on client driver pm_ops.

Reverting this change as we are not able to register I2C
client devices with PM core.

Change-Id: I973a03b7cd0afca2edb584539ea5c69198bfb089
Signed-off-by: default avatarGaurav Singhal <gsinghal@codeaurora.org>
parent ab5c5563

drivers/base/core.c

+1 −7
Original line number Diff line number Diff line
@@ -1116,13 +1116,7 @@ int device_add(struct device *dev) 
	error = dpm_sysfs_add(dev);

	if (error)

		goto DPMError;

	if ((dev->pm_domain) || (dev->type && dev->type->pm)

		|| (dev->class && (dev->class->pm || dev->class->resume))

		|| (dev->bus && (dev->bus->pm || dev->bus->resume)) ||

		(dev->driver && dev->driver->pm)) {

	device_pm_add(dev);

	}





	if (MAJOR(dev->devt)) {

		error = device_create_file(dev, &dev_attr_dev);

drivers/base/power/main.c

+0 −12
Original line number Diff line number Diff line
@@ -162,12 +162,6 @@ void device_pm_move_before(struct device *deva, struct device *devb) 
	pr_debug("PM: Moving %s:%s before %s:%s\n",

		 deva->bus ? deva->bus->name : "No Bus", dev_name(deva),

		 devb->bus ? devb->bus->name : "No Bus", dev_name(devb));

	if (!((devb->pm_domain) || (devb->type && devb->type->pm)

		|| (devb->class && (devb->class->pm || devb->class->resume))

		|| (devb->bus && (devb->bus->pm || devb->bus->resume)) ||

		(devb->driver && devb->driver->pm))) {

		device_pm_add(devb);

	}

	/* Delete deva from dpm_list and reinsert before devb. */

	list_move_tail(&deva->power.entry, &devb->power.entry);

}
@@ -182,12 +176,6 @@ void device_pm_move_after(struct device *deva, struct device *devb) 
	pr_debug("PM: Moving %s:%s after %s:%s\n",

		 deva->bus ? deva->bus->name : "No Bus", dev_name(deva),

		 devb->bus ? devb->bus->name : "No Bus", dev_name(devb));

	if (!((devb->pm_domain) || (devb->type && devb->type->pm)

		|| (devb->class && (devb->class->pm || devb->class->resume))

		|| (devb->bus && (devb->bus->pm || devb->bus->resume)) ||

		(devb->driver && devb->driver->pm))) {

		device_pm_add(devb);

	}

	/* Delete deva from dpm_list and reinsert after devb. */

	list_move(&deva->power.entry, &devb->power.entry);

}