Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fb8918b2 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Wolfram Sang
Browse files

i2c: ismt: PCI core handles power state for us 

There is no need to repeat the work that is already done in the PCI driver
core. Remove suspend and resume callbacks.

Note that there is no more calls performed to enable or disable a PCI
device during suspend-resume cycle. Nowadays they seems to be
superfluous. Someone can read more in [1].

[1] https://www.kernel.org/doc/ols/2009/ols2009-pages-319-330.pdf



Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 600ca080

drivers/i2c/busses/i2c-ismt.c

+0 −33
Original line number Diff line number Diff line
@@ -947,44 +947,11 @@ static void ismt_remove(struct pci_dev *pdev) 
	i2c_del_adapter(&priv->adapter);

}



/**

 * ismt_suspend() - place the device in suspend

 * @pdev: PCI-Express device

 * @mesg: PM message

 */

#ifdef CONFIG_PM

static int ismt_suspend(struct pci_dev *pdev, pm_message_t mesg)

{

	pci_save_state(pdev);

	pci_set_power_state(pdev, pci_choose_state(pdev, mesg));

	return 0;

}



/**

 * ismt_resume() - PCI resume code

 * @pdev: PCI-Express device

 */

static int ismt_resume(struct pci_dev *pdev)

{

	pci_set_power_state(pdev, PCI_D0);

	pci_restore_state(pdev);

	return pci_enable_device(pdev);

}



#else



#define ismt_suspend NULL

#define ismt_resume NULL



#endif



static struct pci_driver ismt_driver = {

	.name = "ismt_smbus",

	.id_table = ismt_ids,

	.probe = ismt_probe,

	.remove = ismt_remove,

	.suspend = ismt_suspend,

	.resume = ismt_resume,

};



module_pci_driver(ismt_driver);