Commit fb586519 authored Feb 26, 2020 by yangerkun Committed by Greg Kroah-Hartman Jun 11, 2020

slip: not call free_netdev before rtnl_unlock in slip_open



commit f596c87005f7b1baeb7d62d9a9e25d68c3dfae10 upstream.

As the description before netdev_run_todo, we cannot call free_netdev
before rtnl_unlock, fix it by reorder the code.

Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to <4.11: free_netdev() is called through sl_free_netdev()]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ab3ec512

drivers/net/slip/slip.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -867,7 +867,10 @@ err_free_chan:
		sl->tty = NULL;
		tty->disc_data = NULL;
		clear_bit(SLF_INUSE, &sl->flags);
		/* do not call free_netdev before rtnl_unlock */
		rtnl_unlock();
		sl_free_netdev(sl->dev);
		return err;

		err_exit:
		rtnl_unlock();