Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fa952c54 authored by Vasant Hegde's avatar Vasant Hegde Committed by Benjamin Herrenschmidt
Browse files

powerpc/powernv: Change BUG_ON to WARN_ON in elog code 



We can continue to read the error log (up to MAX size) even if
we get the elog size more than MAX size. Hence change BUG_ON to
WARN_ON.

Also updated error message.

Reported-by: default avatarGopesh Kumar Chaudhary <gopchaud@in.ibm.com>
Signed-off-by: default avatarVasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: default avatarAnanth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: default avatarDeepthi Dharwar <deepthi@linux.vnet.ibm.com>
Acked-by: default avatarStewart Smith <stewart@linux.vnet.ibm.com>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent 8903461c

arch/powerpc/platforms/powernv/opal-elog.c

+2 −2
Original line number Diff line number Diff line
@@ -249,7 +249,7 @@ static void elog_work_fn(struct work_struct *work) 


	rc = opal_get_elog_size(&id, &size, &type);

	if (rc != OPAL_SUCCESS) {

		pr_err("ELOG: Opal log read failed\n");

		pr_err("ELOG: OPAL log info read failed\n");

		return;

	}
@@ -257,7 +257,7 @@ static void elog_work_fn(struct work_struct *work) 
	log_id = be64_to_cpu(id);

	elog_type = be64_to_cpu(type);



	BUG_ON(elog_size > OPAL_MAX_ERRLOG_SIZE);

	WARN_ON(elog_size > OPAL_MAX_ERRLOG_SIZE);



	if (elog_size >= OPAL_MAX_ERRLOG_SIZE)

		elog_size  =  OPAL_MAX_ERRLOG_SIZE;