Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f766c58f authored by Ira Weiny's avatar Ira Weiny Committed by Doug Ledford
Browse files

IB/mad: Add const qualifiers to query only functions 



The following functions only need read access to the data passed to them.

ib_mad_kernel_rmpp_agent
is_rmpp_data_mad
rcv_has_same_gid
ib_find_send_mad

Clarify with const specifiers

Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 8bf4b30c

drivers/infiniband/core/mad.c

+8 −8
Original line number Diff line number Diff line
@@ -910,7 +910,7 @@ static int alloc_send_rmpp_list(struct ib_mad_send_wr_private *send_wr, 
	return 0;

}



int ib_mad_kernel_rmpp_agent(struct ib_mad_agent *agent)

int ib_mad_kernel_rmpp_agent(const struct ib_mad_agent *agent)

{

	return agent->rmpp_version && !(agent->flags & IB_MAD_USER_RMPP);

}
@@ -1734,8 +1734,8 @@ out: 
	return valid;

}



static int is_rmpp_data_mad(struct ib_mad_agent_private *mad_agent_priv,

		       struct ib_mad_hdr *mad_hdr)

static int is_rmpp_data_mad(const struct ib_mad_agent_private *mad_agent_priv,

			    const struct ib_mad_hdr *mad_hdr)

{

	struct ib_rmpp_mad *rmpp_mad;
@@ -1754,9 +1754,9 @@ static inline int rcv_has_same_class(const struct ib_mad_send_wr_private *wr, 
		rwc->recv_buf.mad->mad_hdr.mgmt_class;

}



static inline int rcv_has_same_gid(struct ib_mad_agent_private *mad_agent_priv,

				   struct ib_mad_send_wr_private *wr,

				   struct ib_mad_recv_wc *rwc )

static inline int rcv_has_same_gid(const struct ib_mad_agent_private *mad_agent_priv,

				   const struct ib_mad_send_wr_private *wr,

				   const struct ib_mad_recv_wc *rwc )

{

	struct ib_ah_attr attr;

	u8 send_resp, rcv_resp;
@@ -1811,8 +1811,8 @@ static inline int is_direct(u8 class) 
}



struct ib_mad_send_wr_private*

ib_find_send_mad(struct ib_mad_agent_private *mad_agent_priv,

		 struct ib_mad_recv_wc *wc)

ib_find_send_mad(const struct ib_mad_agent_private *mad_agent_priv,

		 const struct ib_mad_recv_wc *wc)

{

	struct ib_mad_send_wr_private *wr;

	struct ib_mad *mad;

drivers/infiniband/core/mad_priv.h

+2 −2
Original line number Diff line number Diff line
@@ -213,8 +213,8 @@ struct ib_mad_port_private { 
int ib_send_mad(struct ib_mad_send_wr_private *mad_send_wr);



struct ib_mad_send_wr_private *

ib_find_send_mad(struct ib_mad_agent_private *mad_agent_priv,

		 struct ib_mad_recv_wc *mad_recv_wc);

ib_find_send_mad(const struct ib_mad_agent_private *mad_agent_priv,

		 const struct ib_mad_recv_wc *mad_recv_wc);



void ib_mad_complete_send_wr(struct ib_mad_send_wr_private *mad_send_wr,

			     struct ib_mad_send_wc *mad_send_wc);

include/rdma/ib_mad.h

+1 −1
Original line number Diff line number Diff line
@@ -675,6 +675,6 @@ void ib_free_send_mad(struct ib_mad_send_buf *send_buf); 
 * @agent: the agent in question

 * @return: true if agent is performing rmpp, false otherwise.

 */

int ib_mad_kernel_rmpp_agent(struct ib_mad_agent *agent);

int ib_mad_kernel_rmpp_agent(const struct ib_mad_agent *agent);



#endif /* IB_MAD_H */