Commit f59604a8 authored Mar 21, 2020 by Oliver Hartkopp Committed by Greg Kroah-Hartman Apr 02, 2020

slcan: not call free_netdev before rtnl_unlock in slcan_open



[ Upstream commit 2091a3d42b4f339eaeed11228e0cbe9d4f92f558 ]

As the description before netdev_run_todo, we cannot call free_netdev
before rtnl_unlock, fix it by reorder the code.

This patch is a 1:1 copy of upstream slip.c commit f596c87005f7
("slip: not call free_netdev before rtnl_unlock in slip_open").

Reported-by: yangerkun <yangerkun@huawei.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 14de358f

drivers/net/can/slcan.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -621,7 +621,10 @@ err_free_chan:
		tty->disc_data = NULL;
		clear_bit(SLF_INUSE, &sl->flags);
		slc_free_netdev(sl->dev);
		/* do not call free_netdev before rtnl_unlock */
		rtnl_unlock();
		free_netdev(sl->dev);
		return err;

		err_exit:
		rtnl_unlock();