Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f265be3d authored by Alexander Aring's avatar Alexander Aring Committed by Marcel Holtmann
Browse files

mac802154: remove aack hw flag 



This patch removes the hardware auto acknowdledge flag which indicates
that the transceiver supports this handling. This flag is never
evaluated inside mac802154 and all transceivers should support this
handling by default per hardware.

Suggested-by: default avatarLennert Buytenhek <buytenh@wantstofly.org>
Cc: Alan Ott <alan@signal11.us>
Signed-off-by: default avatarAlexander Aring <alex.aring@gmail.com>
Reviewed-by: default avatarVarka Bhadram <varkabhadram@gmail.com>
Acked-by: default avatarStefan Schmidt <stefan@osg.samsung.com>
Acked-by: default avatarVarka Bhadram <varkabhadram@gmail.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 6b70a43c

drivers/net/ieee802154/at86rf230.c

+1 −1
Original line number Diff line number Diff line
@@ -1443,7 +1443,7 @@ at86rf230_detect_device(struct at86rf230_local *lp) 
		return -EINVAL;

	}



	lp->hw->flags = IEEE802154_HW_TX_OMIT_CKSUM | IEEE802154_HW_AACK |

	lp->hw->flags = IEEE802154_HW_TX_OMIT_CKSUM |

			IEEE802154_HW_CSMA_PARAMS |

			IEEE802154_HW_FRAME_RETRIES | IEEE802154_HW_AFILT |

			IEEE802154_HW_PROMISCUOUS;

drivers/net/ieee802154/atusb.c

+1 −1
Original line number Diff line number Diff line
@@ -628,7 +628,7 @@ static int atusb_probe(struct usb_interface *interface, 


	hw->parent = &usb_dev->dev;

	hw->flags = IEEE802154_HW_TX_OMIT_CKSUM | IEEE802154_HW_AFILT |

		    IEEE802154_HW_AACK | IEEE802154_HW_PROMISCUOUS;

		    IEEE802154_HW_PROMISCUOUS;



	hw->phy->flags = WPAN_PHY_FLAG_TXPOWER;

drivers/net/ieee802154/cc2520.c

+1 −2
Original line number Diff line number Diff line
@@ -746,8 +746,7 @@ static int cc2520_register(struct cc2520_private *priv) 


	/* We do support only 2.4 Ghz */

	priv->hw->phy->supported.channels[0] = 0x7FFF800;

	priv->hw->flags = IEEE802154_HW_OMIT_CKSUM | IEEE802154_HW_AACK |

			  IEEE802154_HW_AFILT;

	priv->hw->flags = IEEE802154_HW_OMIT_CKSUM | IEEE802154_HW_AFILT;



	priv->hw->phy->flags = WPAN_PHY_FLAG_TXPOWER;

drivers/net/ieee802154/mrf24j40.c

+1 −2
Original line number Diff line number Diff line
@@ -751,8 +751,7 @@ static int mrf24j40_probe(struct spi_device *spi) 
	devrec->hw->priv = devrec;

	devrec->hw->parent = &devrec->spi->dev;

	devrec->hw->phy->supported.channels[0] = CHANNEL_MASK;

	devrec->hw->flags = IEEE802154_HW_OMIT_CKSUM | IEEE802154_HW_AACK |

			    IEEE802154_HW_AFILT;

	devrec->hw->flags = IEEE802154_HW_OMIT_CKSUM | IEEE802154_HW_AFILT;



	dev_dbg(printdev(devrec), "registered mrf24j40\n");

	ret = ieee802154_register_hw(devrec->hw);

include/net/mac802154.h

+0 −2
Original line number Diff line number Diff line
@@ -90,8 +90,6 @@ struct ieee802154_hw { 


/* Indicates that xmitter will add FCS on it's own. */

#define IEEE802154_HW_TX_OMIT_CKSUM	0x00000001

/* Indicates that receiver will autorespond with ACK frames. */

#define IEEE802154_HW_AACK		0x00000002

/* Indicates that transceiver will support listen before transmit. */

#define IEEE802154_HW_LBT		0x00000004

/* Indicates that transceiver will support csma (max_be, min_be, csma retries)