Commit f0fcd7a9 authored Apr 09, 2013 by Nithin Sujir Committed by David S. Miller Apr 09, 2013

tg3: Fix flow control settings not propagated to hardware



In tg3_setup_copper_phy(), if autonegotiation is disabled, we need to
relink only if the speed or duplex does not match the configured
setting.  If flow control does not match, a relink is not necessary as
flow control is not a PHY setting.  Later on, we'll call
tg3_setup_flow_ctrl() to set up the MAC to the desired flow control
settings if we're in full duplex mode.

Signed-off-by: Nithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1b866434

drivers/net/ethernet/broadcom/tg3.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -4587,9 +4587,7 @@ static int tg3_setup_copper_phy(struct tg3 *tp, int force_reset)
		} else {
		if (!(bmcr & BMCR_ANENABLE) &&
		tp->link_config.speed == current_speed &&
		tp->link_config.duplex == current_duplex &&
		tp->link_config.flowctrl ==
		tp->link_config.active_flowctrl) {
		tp->link_config.duplex == current_duplex) {
		current_link_up = 1;
		}
		}