Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0ce7ee3 authored by David Howells's avatar David Howells Committed by James Morris
Browse files

CRED: Wrap task credential accesses in the FAT filesystem 



Wrap access to task credentials so that they can be separated more easily from
the task_struct during the introduction of COW creds.

Change most current->(|e|s|fs)[ug]id to current_(|e|s|fs)[ug]id().

Change some task->e?[ug]id to task_e?[ug]id().  In some places it makes more
sense to use RCU directly rather than a convenient wrapper; these will be
addressed by later patches.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Reviewed-by: default avatarJames Morris <jmorris@namei.org>
Acked-by: default avatarSerge Hallyn <serue@us.ibm.com>
Acked-by: default avatarOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent 4c9c544e

fs/fat/file.c

+1 −1
Original line number Diff line number Diff line
@@ -302,7 +302,7 @@ static int fat_allow_set_time(struct msdos_sb_info *sbi, struct inode *inode) 
{

	mode_t allow_utime = sbi->options.allow_utime;



	if (current->fsuid != inode->i_uid) {

	if (current_fsuid() != inode->i_uid) {

		if (in_group_p(inode->i_gid))

			allow_utime >>= 3;

		if (allow_utime & MAY_WRITE)

fs/fat/inode.c

+2 −2
Original line number Diff line number Diff line
@@ -921,8 +921,8 @@ static int parse_options(char *options, int is_vfat, int silent, int *debug, 


	opts->isvfat = is_vfat;



	opts->fs_uid = current->uid;

	opts->fs_gid = current->gid;

	opts->fs_uid = current_uid();

	opts->fs_gid = current_gid();

	opts->fs_fmask = opts->fs_dmask = current->fs->umask;

	opts->allow_utime = -1;

	opts->codepage = fat_default_codepage;