Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ef24d642 authored by Takashi Iwai's avatar Takashi Iwai Committed by Greg Kroah-Hartman
Browse files

ALSA: hda - Clear the leftover component assignment at snd_hdac_i915_exit() 

commit faafd03d23c913633d2ef7e6ffebdce01b164409 upstream.

The commit [d745f5e7b8b2: ALSA: hda - Add the pin / port mapping on
Intel ILK and VLV] introduced a WARN_ON() to check the pointer for
avoiding the double initializations.  But hdac_acomp pointer wasn't
cleared at snd_hdac_i915_exit(), thus after reloading the HD-audio
driver, it may result in the false positive warning.  This patch makes
sure to clear the leftover pointer at exit.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94736


Reported-by: default avatarDaniela Doras-prodan <daniela.doras-prodan@intel.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Cc: Kouta Okamoto <kouta.okamoto@toshiba.co.jp>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7f3e85d8

sound/hda/hdac_i915.c

+1 −0
Original line number Diff line number Diff line
@@ -273,6 +273,7 @@ int snd_hdac_i915_exit(struct hdac_bus *bus) 


	kfree(acomp);

	bus->audio_component = NULL;

	hdac_acomp = NULL;



	return 0;

}