Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ecd77ebf authored by Ley Foon Tan's avatar Ley Foon Tan Committed by Greg Kroah-Hartman
Browse files

PCI: altera: Fix altera_pcie_link_is_up() 



commit eff31f4002c4e25b9b8c39d0a3a551c6c64c77e8 upstream.

Originally altera_pcie_link_is_up() decided the link was up if any of the
low four bits of the LTSSM register were set.  But the link is only up if
the LTSSM state is L0, so check for that exact value.

[bhelgaas: changelog]
Signed-off-by: default avatarLey Foon Tan <lftan@altera.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Cc: Claudius Heine <claudius.heine.ext@siemens.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 271137c0

drivers/pci/host/pcie-altera.c

+2 −1
Original line number Diff line number Diff line
@@ -40,6 +40,7 @@ 
#define P2A_INT_ENABLE			0x3070

#define P2A_INT_ENA_ALL			0xf

#define RP_LTSSM			0x3c64

#define RP_LTSSM_MASK			0x1f

#define LTSSM_L0			0xf



/* TLP configuration type 0 and 1 */
@@ -140,7 +141,7 @@ static void tlp_write_tx(struct altera_pcie *pcie, 


static bool altera_pcie_link_is_up(struct altera_pcie *pcie)

{

	return !!(cra_readl(pcie, RP_LTSSM) & LTSSM_L0);

	return !!((cra_readl(pcie, RP_LTSSM) & RP_LTSSM_MASK) == LTSSM_L0);

}



static bool altera_pcie_valid_config(struct altera_pcie *pcie,