Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ec6995dd authored by Steve Wise's avatar Steve Wise Committed by Roland Dreier
Browse files

RDMA/cxgb3: Don't complete flushed send work requests twice 



When the SQ is flushed, mark the flushed entries as not signaled so
the poll logic doesn't re-insert the CQ entry thinking its an out of
order completion.

The bug can cause the NFS/RDMA server to crash due to processing the
same completed work request twice.

Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
parent 56a50add

drivers/infiniband/hw/cxgb3/cxio_hal.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -410,6 +410,7 @@ int cxio_flush_sq(struct t3_wq *wq, struct t3_cq *cq, int count) 
	ptr = wq->sq_rptr + count;

	ptr = wq->sq_rptr + count;

	sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);

	sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);

	while (ptr != wq->sq_wptr) {

	while (ptr != wq->sq_wptr) {

		sqp->signaled = 0;

		insert_sq_cqe(wq, cq, sqp);

		insert_sq_cqe(wq, cq, sqp);

		ptr++;

		ptr++;

		sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);

		sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);