Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit eb939922 authored by Rusty Russell's avatar Rusty Russell Committed by David S. Miller
Browse files

module_param: make bool parameters really bool (net & drivers/net) 



module_param(bool) used to counter-intuitively take an int.  In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.

It's time to remove the int/unsigned int option.  For this version
it'll simply give a warning, but it'll break next kernel version.

(Thanks to Joe Perches for suggesting coccinelle for 0/1 -> true/false).

Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3db1cd5c

drivers/net/caif/caif_serial.c

+3 −3
Original line number Diff line number Diff line
@@ -38,15 +38,15 @@ MODULE_ALIAS_LDISC(N_CAIF); 
/*This list is protected by the rtnl lock. */

static LIST_HEAD(ser_list);



static int ser_loop;

static bool ser_loop;

module_param(ser_loop, bool, S_IRUGO);

MODULE_PARM_DESC(ser_loop, "Run in simulated loopback mode.");



static int ser_use_stx = 1;

static bool ser_use_stx = true;

module_param(ser_use_stx, bool, S_IRUGO);

MODULE_PARM_DESC(ser_use_stx, "STX enabled or not.");



static int ser_use_fcs = 1;

static bool ser_use_fcs = true;



module_param(ser_use_fcs, bool, S_IRUGO);

MODULE_PARM_DESC(ser_use_fcs, "FCS enabled or not.");

drivers/net/caif/caif_spi.c

+1 −1
Original line number Diff line number Diff line
@@ -35,7 +35,7 @@ MODULE_DESCRIPTION("CAIF SPI driver"); 
/* Returns the number of padding bytes for alignment. */

#define PAD_POW2(x, pow) ((((x)&((pow)-1))==0) ? 0 : (((pow)-((x)&((pow)-1)))))



static int spi_loop;

static bool spi_loop;

module_param(spi_loop, bool, S_IRUGO);

MODULE_PARM_DESC(spi_loop, "SPI running in loopback mode.");

drivers/net/can/vcan.c

+1 −1
Original line number Diff line number Diff line
@@ -63,7 +63,7 @@ MODULE_AUTHOR("Urs Thuermann <urs.thuermann@volkswagen.de>"); 
 * See Documentation/networking/can.txt for details.

 */



static int echo; /* echo testing. Default: 0 (Off) */

static bool echo; /* echo testing. Default: 0 (Off) */

module_param(echo, bool, S_IRUGO);

MODULE_PARM_DESC(echo, "Echo sent frames (for testing). Default: 0 (Off)");

drivers/net/ethernet/amd/amd8111e.h

+2 −2
Original line number Diff line number Diff line
@@ -807,8 +807,8 @@ typedef enum { 


static int card_idx;

static int speed_duplex[MAX_UNITS] = { 0, };

static int coalesce[MAX_UNITS] = {1,1,1,1,1,1,1,1};

static int dynamic_ipg[MAX_UNITS] = {0,0,0,0,0,0,0,0};

static bool coalesce[MAX_UNITS] = { [ 0 ... MAX_UNITS-1] = true };

static bool dynamic_ipg[MAX_UNITS] = { [ 0 ... MAX_UNITS-1] = false };

static unsigned int chip_version;



#endif /* _AMD8111E_H */

drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c

+1 −1
Original line number Diff line number Diff line
@@ -243,7 +243,7 @@ module_param_array(intr_cnt, uint, NULL, 0644); 
MODULE_PARM_DESC(intr_cnt,

		 "thresholds 1..3 for queue interrupt packet counters");



static int vf_acls;

static bool vf_acls;



#ifdef CONFIG_PCI_IOV

module_param(vf_acls, bool, 0644);