Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e9b5a982 authored by Manfred Schlaegl's avatar Manfred Schlaegl Committed by Greg Kroah-Hartman
Browse files

serial: imx: reduce irq-latency after rx overflow



To prevent problems with interrupt latency, and due to the fact, that
the error will be counted anyway (icount.overrun), the dev_err is simply
removed.

Background:
If an rx-fifo overflow occurs a dev_err message was called in interrupt
context. Since dev_err messages are written to console in a synchronous way
(unbuffered), and console may be a serial terminal, this leads to a
highly increased interrupt-latency (several milliseconds).
As a result of the high latency more rx-fifo overflows will happen, and
therefore a feedback loop of errors is created.

Signed-off-by: default avatarManfred Schlaegl <manfred.schlaegl@gmx.at>
Acked-By: default avatarAlexander Stein <alexander.stein@systec-electronic.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9b289932
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -767,7 +767,6 @@ static irqreturn_t imx_int(int irq, void *dev_id)
		writel(USR1_AWAKE, sport->port.membase + USR1);

	if (sts2 & USR2_ORE) {
		dev_err(sport->port.dev, "Rx FIFO overrun\n");
		sport->port.icount.overrun++;
		writel(USR2_ORE, sport->port.membase + USR2);
	}