Commit e8505e64 authored Apr 07, 2017 by Liping Zhang Committed by Greg Kroah-Hartman Jul 15, 2017

sysctl: don't print negative flag for proc_douintvec



commit 5380e5644afbba9e3d229c36771134976f05c91e upstream.

I saw some very confusing sysctl output on my system:
  # cat /proc/sys/net/core/xfrm_aevent_rseqth
  -2
  # cat /proc/sys/net/core/xfrm_aevent_etime
  -10
  # cat /proc/sys/net/ipv4/tcp_notsent_lowat
  -4294967295

Because we forget to set the *negp flag in proc_douintvec, so it will
become a garbage value.

Since the value related to proc_douintvec is always an unsigned integer,
so we can set *negp to false explictily to fix this issue.

Fixes: e7d316a02f68 ("sysctl: handle error writing UINT_MAX to u32 fields")
Signed-off-by: Liping Zhang <zlpnobody@gmail.com>
Cc: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2e42225b

kernel/sysctl.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2070,6 +2070,7 @@ static int do_proc_douintvec_conv(bool negp, unsigned long lvalp,
		valp = lvalp;
		} else {
		unsigned int val = *valp;
		*negp = false;
		*lvalp = (unsigned long)val;
		}
		return 0;