Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit debd1abd authored by Sayali Lokhande's avatar Sayali Lokhande Committed by Gerrit - the friendly Code Review server
Browse files

scsi: ufs: Fix off-by-one bug in ufs debugfs driver 



When getting string from userspace by simple_write_to_buffer
in ufs_qcom_dbg_testbus_cfg_write() function, null byte may
be written out of bounds of configuration buffer if return
value is same as size of buffer, causing off-by-one bug.
This change passes correct available size of configuration
buffer to simple_write_to_buffer function.

Change-Id: If6085e806aa34622a9a57b02f563869c51011d2f
Signed-off-by: default avatarSayali Lokhande <sayalil@codeaurora.org>
parent 0cdce1ee

drivers/scsi/ufs/ufs-qcom-debugfs.c

+2 −1
Original line number Diff line number Diff line
@@ -121,7 +121,8 @@ static ssize_t ufs_qcom_dbg_testbus_cfg_write(struct file *file, 
	struct ufs_hba *hba = host->hba;





	ret = simple_write_to_buffer(configuration, TESTBUS_CFG_BUFF_LINE_SIZE,

	ret = simple_write_to_buffer(configuration,

		TESTBUS_CFG_BUFF_LINE_SIZE - 1,

		&buff_pos, ubuf, cnt);

	if (ret < 0) {

		dev_err(host->hba->dev, "%s: failed to read user data\n",