Commit de8f8bd6 authored Jul 13, 2009 by Oliver Neukum Committed by Greg Kroah-Hartman Jul 28, 2009

Staging: serqt_usb2: fix memory leak in error case



a standard memory leak, as later allocations may fail even if prior
allocations did not. Then the prior allocations must be undone.

Signed-off-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent f3a75688

drivers/staging/serqt_usb2/serqt_usb2.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -738,6 +738,11 @@ static int qt_startup(struct usb_serial *serial)
		if (!qt_port) {
		dbg("%s: kmalloc for quatech_port (%d) failed!.",
		__func__, i);
		for(--i; i >= 0; i--) {
		port = serial->port[i];
		kfree(usb_get_serial_port_data(port));
		usb_set_serial_port_data(port, NULL);
		}
		return -ENOMEM;
		}
		spin_lock_init(&qt_port->lock);