Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc6341c4 authored by Ezequiel García's avatar Ezequiel García Committed by Mauro Carvalho Chehab
Browse files

[media] s5p-jpeg: Remove unneeded struct vb2_queue clear on queue_init() 



queue_init() is always called by v4l2_m2m_ctx_init(), which allocates
a context struct v4l2_m2m_ctx with kzalloc.
Therefore, there is no need to clear vb2_queue src/dst structs.

Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: default avatarEzequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 73dad42e

drivers/media/platform/s5p-jpeg/jpeg-core.c

+0 −2
Original line number Diff line number Diff line
@@ -1223,7 +1223,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, 
	struct s5p_jpeg_ctx *ctx = priv;

	int ret;



	memset(src_vq, 0, sizeof(*src_vq));

	src_vq->type = V4L2_BUF_TYPE_VIDEO_OUTPUT;

	src_vq->io_modes = VB2_MMAP | VB2_USERPTR;

	src_vq->drv_priv = ctx;
@@ -1235,7 +1234,6 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, 
	if (ret)

		return ret;



	memset(dst_vq, 0, sizeof(*dst_vq));

	dst_vq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE;

	dst_vq->io_modes = VB2_MMAP | VB2_USERPTR;

	dst_vq->drv_priv = ctx;