Commit db643130 authored Jun 27, 2018 by Zhen Lei Committed by Greg Kroah-Hartman Jun 11, 2020

esp6: fix memleak on error path in esp6_input



commit 7284fdf39a912322ce97de2d30def3c6068a418c upstream.

This ought to be an omission in e6194923237 ("esp: Fix memleaks on error
paths."). The memleak on error path in esp6_input is similar to esp_input
of esp4.

Fixes: e6194923237 ("esp: Fix memleaks on error paths.")
Fixes: 3f29770723f ("ipsec: check return value of skb_to_sgvec always")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 37902e44

net/ipv6/esp6.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -426,8 +426,10 @@ static int esp6_input(struct xfrm_state x, struct sk_buff skb)

		sg_init_table(sg, nfrags);
		ret = skb_to_sgvec(skb, sg, 0, skb->len);
		if (unlikely(ret < 0))
		if (unlikely(ret < 0)) {
		kfree(tmp);
		goto out;
		}

		aead_request_set_crypt(req, sg, sg, elen + ivlen, iv);
		aead_request_set_ad(req, assoclen);