Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit db15caa8 authored by Prakash Gupta's avatar Prakash Gupta Committed by Gerrit - the friendly Code Review server
Browse files

iommu: free io pgtable during domain detach. 



Pagetable pgd is allocated in arm_smmu_init_domain_context and is freed in
arm_smmu_domain_free. Client can attach/detach domain without freeing the
same. This causes memory leak. This was introduced with
commit fe676929 ("iommu/arm-smmu: fix a DOMAIN_ATTR_DYNAMIC memory
leak")

Free io pgtables in arm_smmu_destroy_domain_context, which is invoked at
the time of domain detach.

Change-Id: Ib53e4efdd8dca33437596f3f0ccaa8ccaae79ca0
Signed-off-by: default avatarPrakash Gupta <guptap@codeaurora.org>
parent 7eede150

drivers/iommu/arm-smmu.c

+12 −2
Original line number Diff line number Diff line
@@ -1956,10 +1956,20 @@ static void arm_smmu_destroy_domain_context(struct iommu_domain *domain) 
	cb_base = ARM_SMMU_CB_BASE(smmu) + ARM_SMMU_CB(smmu, cfg->cbndx);

	writel_relaxed(0, cb_base + ARM_SMMU_CB_SCTLR);



	arm_smmu_tlb_inv_context(smmu_domain);



	arm_smmu_disable_clocks(smmu_domain->smmu);



	if (smmu_domain->pgtbl_ops) {

		free_io_pgtable_ops(smmu_domain->pgtbl_ops);

		/* unassign any freed page table memory */

		if (arm_smmu_is_master_side_secure(smmu_domain)) {

			arm_smmu_secure_domain_lock(smmu_domain);

			arm_smmu_secure_pool_destroy(smmu_domain);

			arm_smmu_unassign_table(smmu_domain);

			arm_smmu_secure_domain_unlock(smmu_domain);

		}

		smmu_domain->pgtbl_ops = NULL;

	}



free_irqs:

	if (cfg->irptndx != INVALID_IRPTNDX) {

		irq = smmu->irqs[smmu->num_global_irqs + cfg->irptndx];