Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d9bdeba0 authored by Abhinav Kumar's avatar Abhinav Kumar
Browse files

drm/msm : fix hdmi controller register programming 



Currently, there is an incorrect programming of the
hdmi controller register where default value of the
datapath mode bit is being toggled along with the
scrambler enable/disable.

This bit should be untouched as per the hardware
programming sequence and kept at the default state.

Fix the register programming to avoid toggling this
bit.

Change-Id: I2e8f74c0abaddd27b5d8a2136afc4e1b82f96e7d
Signed-off-by: default avatarAbhinav Kumar <abhinavk@codeaurora.org>
parent ccde34ff

drivers/gpu/drm/msm/hdmi-staging/sde_hdmi_bridge.c

+0 −2
Original line number Diff line number Diff line
@@ -328,7 +328,6 @@ static int _sde_hdmi_bridge_setup_scrambler(struct hdmi *hdmi, 
		}



		reg_val = hdmi_read(hdmi, REG_HDMI_CTRL);

		reg_val |= BIT(31); /* Enable Update DATAPATH_MODE */

		reg_val |= BIT(28); /* Set SCRAMBLER_EN bit */



		hdmi_write(hdmi, REG_HDMI_CTRL, reg_val);
@@ -360,7 +359,6 @@ static int _sde_hdmi_bridge_setup_scrambler(struct hdmi *hdmi, 
	} else {

		sde_hdmi_scdc_write(hdmi, HDMI_TX_SCDC_SCRAMBLING_ENABLE, 0x0);

		reg_val = hdmi_read(hdmi, REG_HDMI_CTRL);

		reg_val &= ~BIT(31); /* Disable Update DATAPATH_MODE */

		reg_val &= ~BIT(28); /* Unset SCRAMBLER_EN bit */

		hdmi_write(hdmi, REG_HDMI_CTRL, reg_val);

	}