Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d98a0641 authored by Richard Weinberger's avatar Richard Weinberger Committed by Greg Kroah-Hartman
Browse files

ubifs: Fix xattr_names length in exit paths 



commit 843741c5778398ea67055067f4cc65ae6c80ca0e upstream.

When the operation fails we also have to undo the changes
we made to ->xattr_names. Otherwise listxattr() will report
wrong lengths.

Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 795422ec

fs/ubifs/xattr.c

+2 −0
Original line number Diff line number Diff line
@@ -173,6 +173,7 @@ out_cancel: 
	host_ui->xattr_cnt -= 1;

	host_ui->xattr_size -= CALC_DENT_SIZE(nm->len);

	host_ui->xattr_size -= CALC_XATTR_BYTES(size);

	host_ui->xattr_names -= nm->len;

	mutex_unlock(&host_ui->ui_mutex);

out_free:

	make_bad_inode(inode);
@@ -533,6 +534,7 @@ out_cancel: 
	host_ui->xattr_cnt += 1;

	host_ui->xattr_size += CALC_DENT_SIZE(nm->len);

	host_ui->xattr_size += CALC_XATTR_BYTES(ui->data_len);

	host_ui->xattr_names += nm->len;

	mutex_unlock(&host_ui->ui_mutex);

	ubifs_release_budget(c, &req);

	make_bad_inode(inode);