Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d906d61c authored by Sergei Shtylyov's avatar Sergei Shtylyov Committed by Felipe Balbi
Browse files

usb: dummy_hcd: use HUB_CHAR_* 



Fix  using the  bare numbers to set the 'wHubCharacteristics' field of the Hub
Descriptor while the values are #define'd in <linux/usb/ch11.h>.

Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 3d040de8

drivers/usb/gadget/udc/dummy_hcd.c

+6 −2
Original line number Diff line number Diff line
@@ -1924,7 +1924,9 @@ ss_hub_descriptor(struct usb_hub_descriptor *desc) 
	memset(desc, 0, sizeof *desc);

	desc->bDescriptorType = 0x2a;

	desc->bDescLength = 12;

	desc->wHubCharacteristics = cpu_to_le16(0x0001);

	desc->wHubCharacteristics = cpu_to_le16(

			HUB_CHAR_INDV_PORT_LPSM |

			HUB_CHAR_COMMON_OCPM);

	desc->bNbrPorts = 1;

	desc->u.ss.bHubHdrDecLat = 0x04; /* Worst case: 0.4 micro sec*/

	desc->u.ss.DeviceRemovable = 0xffff;
@@ -1935,7 +1937,9 @@ static inline void hub_descriptor(struct usb_hub_descriptor *desc) 
	memset(desc, 0, sizeof *desc);

	desc->bDescriptorType = 0x29;

	desc->bDescLength = 9;

	desc->wHubCharacteristics = cpu_to_le16(0x0001);

	desc->wHubCharacteristics = cpu_to_le16(

			HUB_CHAR_INDV_PORT_LPSM |

			HUB_CHAR_COMMON_OCPM);

	desc->bNbrPorts = 1;

	desc->u.hs.DeviceRemovable[0] = 0xff;

	desc->u.hs.DeviceRemovable[1] = 0xff;