Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7a2c259 authored by Brian Norris's avatar Brian Norris Committed by Greg Kroah-Hartman
Browse files

mwifiex: printk() overflow with 32-byte SSIDs 



commit fcd2042e8d36cf644bd2d69c26378d17158b17df upstream.

SSIDs aren't guaranteed to be 0-terminated. Let's cap the max length
when we print them out.

This can be easily noticed by connecting to a network with a 32-octet
SSID:

[ 3903.502925] mwifiex_pcie 0000:01:00.0: info: trying to associate to
'0123456789abcdef0123456789abcdef <uninitialized mem>' bssid
xx:xx:xx:xx:xx:xx

Fixes: 5e6e3a92 ("wireless: mwifiex: initial commit for Marvell mwifiex driver")
Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Acked-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ac6e42d7

drivers/net/wireless/mwifiex/cfg80211.c

+7 −6
Original line number Diff line number Diff line
@@ -2144,8 +2144,9 @@ done: 
			is_scanning_required = 1;

		} else {

			mwifiex_dbg(priv->adapter, MSG,

				    "info: trying to associate to '%s' bssid %pM\n",

				    (char *)req_ssid.ssid, bss->bssid);

				    "info: trying to associate to '%.*s' bssid %pM\n",

				    req_ssid.ssid_len, (char *)req_ssid.ssid,

				    bss->bssid);

			memcpy(&priv->cfg_bssid, bss->bssid, ETH_ALEN);

			break;

		}
@@ -2202,8 +2203,8 @@ mwifiex_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev, 
	}



	mwifiex_dbg(adapter, INFO,

		    "info: Trying to associate to %s and bssid %pM\n",

		    (char *)sme->ssid, sme->bssid);

		    "info: Trying to associate to %.*s and bssid %pM\n",

		    (int)sme->ssid_len, (char *)sme->ssid, sme->bssid);



	ret = mwifiex_cfg80211_assoc(priv, sme->ssid_len, sme->ssid, sme->bssid,

				     priv->bss_mode, sme->channel, sme, 0);
@@ -2333,8 +2334,8 @@ mwifiex_cfg80211_join_ibss(struct wiphy *wiphy, struct net_device *dev, 
	}



	mwifiex_dbg(priv->adapter, MSG,

		    "info: trying to join to %s and bssid %pM\n",

		    (char *)params->ssid, params->bssid);

		    "info: trying to join to %.*s and bssid %pM\n",

		    params->ssid_len, (char *)params->ssid, params->bssid);



	mwifiex_set_ibss_params(priv, params);