Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d72cb5fb authored by Anoob Soman's avatar Anoob Soman Committed by Greg Kroah-Hartman
Browse files

packet: call fanout_release, while UNREGISTERING a netdev 



[ Upstream commit 6664498280cf17a59c3e7cf1a931444c02633ed1 ]

If a socket has FANOUT sockopt set, a new proto_hook is registered
as part of fanout_add(). When processing a NETDEV_UNREGISTER event in
af_packet, __fanout_unlink is called for all sockets, but prot_hook which was
registered as part of fanout_add is not removed. Call fanout_release, on a
NETDEV_UNREGISTER, which removes prot_hook and removes fanout from the
fanout_list.

This fixes BUG_ON(!list_empty(&dev->ptype_specific)) in netdev_run_todo()

Signed-off-by: default avatarAnoob Soman <anoob.soman@citrix.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 63091b2c

net/packet/af_packet.c

+1 −0
Original line number Diff line number Diff line
@@ -3855,6 +3855,7 @@ static int packet_notifier(struct notifier_block *this, 
				}

				if (msg == NETDEV_UNREGISTER) {

					packet_cached_dev_reset(po);

					fanout_release(sk);

					po->ifindex = -1;

					if (po->prot_hook.dev)

						dev_put(po->prot_hook.dev);