Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d429fb06 authored by Mohammed Javid's avatar Mohammed Javid
Browse files

msm: ipa: freeing null pointer causing device crash



Adding check to verify the pointer null or not
before freeing the pointer.

Change-Id: Id6fd3d1d099ed545083338192d644790574b1a9c
Acked-by: default avatarAshok Vuyyuru <avuyyuru@qti.qualcomm.com>
Signed-off-by: default avatarMohammed Javid <mjavid@codeaurora.org>
parent 0859d3c0
Loading
Loading
Loading
Loading
+7 −5
Original line number Diff line number Diff line
@@ -725,12 +725,14 @@ void ipa_nat_free_mem_and_device(struct ipa_nat_mem *nat_ctx)

	if (nat_ctx->is_sys_mem) {
		IPADBG("freeing the dma memory\n");
		if (nat_ctx->vaddr) {
			dma_free_coherent(
				ipa_ctx->pdev, nat_ctx->size,
				nat_ctx->vaddr, nat_ctx->dma_handle);
			nat_ctx->size = 0;
			nat_ctx->vaddr = NULL;
		}
	}
	nat_ctx->is_mapped = false;
	nat_ctx->is_sys_mem = false;
	nat_ctx->is_dev_init = false;
+7 −5
Original line number Diff line number Diff line
@@ -719,12 +719,14 @@ void ipa3_nat_free_mem_and_device(struct ipa3_nat_mem *nat_ctx)

	if (nat_ctx->is_sys_mem) {
		IPADBG("freeing the dma memory\n");
		if (nat_ctx->vaddr) {
			dma_free_coherent(
				ipa3_ctx->pdev, nat_ctx->size,
				nat_ctx->vaddr, nat_ctx->dma_handle);
			nat_ctx->size = 0;
			nat_ctx->vaddr = NULL;
		}
	}
	nat_ctx->is_mapped = false;
	nat_ctx->is_sys_mem = false;
	nat_ctx->is_dev_init = false;